Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use exhaustive match in const_prop.rs #73693

Merged
merged 1 commit into from
Jul 4, 2020
Merged

Use exhaustive match in const_prop.rs #73693

merged 1 commit into from
Jul 4, 2020

Conversation

wesleywiser
Copy link
Member

Addresses a comment left by @RalfJung on #73613

r? @RalfJung

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 24, 2020
RalfJung
RalfJung reviewed Jun 24, 2020
View reviewed changes
src/librustc_mir/transform/const_prop.rs
| Rvalue::Cast(..)
| Rvalue::Discriminant(..)
| Rvalue::AddressOf(..)
| Rvalue::NullaryOp(..) => {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the justification for doing nothing for all of these?

I don't actually understand this code, maybe it would be better if @oli-obk reviewed this.^^

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to have a brief comment here saying why it is okay to ignore these.

@rust-highfive

This comment has been minimized.

Sign in to view
@RalfJung
Copy link
Member

r? @oli-obk

@rust-highfive rust-highfive assigned oli-obk and unassigned RalfJung Jun 29, 2020
@oli-obk oli-obk added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2020
@wesleywiser wesleywiser force-pushed the const_prop_exhaustive_match branch from e7920b2 to b4d0457 Compare July 1, 2020 00:51
@wesleywiser
Copy link
Member Author

Rebased and add a comment.

@oli-obk
Copy link
Contributor

oli-obk commented Jul 3, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Jul 3, 2020

📌 Commit b4d0457 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 3, 2020
@wesleywiser
Copy link
Member Author

@bors rollup

@bors
Copy link
Contributor

bors commented Jul 3, 2020

⌛ Testing commit b4d0457 with merge 3f1a04d3651282e361fd66c2375f91a5ed78f1d6...

@bors
Copy link
Contributor

bors commented Jul 3, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 3, 2020
@wesleywiser
Copy link
Member Author

Looks like a networking issue or something?

error: failed to get `cc` as a dependency of package `bootstrap v0.0.0 (/checkout/src/bootstrap)`

Caused by:
  failed to fetch `https://github.com/rust-lang/crates.io-index`

Caused by:
  error inflating zlib stream; class=Zlib (5)
failed to run: /checkout/obj/build/i686-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
Build completed unsuccessfully in 0:00:26

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented Jul 3, 2020

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: Fix "getting started" link #73985

@bors
Copy link
Contributor

bors commented Jul 3, 2020

📌 Commit b4d0457 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2020
@RalfJung
Copy link
Member

RalfJung commented Jul 3, 2020

The command to re-run CI is
@bors retry

@RalfJung RalfJung mentioned this pull request Jul 3, 2020
Closed
@Manishearth Manishearth mentioned this pull request Jul 4, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 4, 2020
@bors
Auto merge of rust-lang#74019 - Manishearth:rollup-2st3jsk, r=Manishe…
dbf3ae7 
…arth

Rollup of 12 pull requests

Successful merges:

 - rust-lang#73140 (Fallback to xml.etree.ElementTree)
 - rust-lang#73670 (Add `format_args_capture` feature)
 - rust-lang#73693 (Use exhaustive match in const_prop.rs)
 - rust-lang#73845 (Use &raw in A|Rc::as_ptr)
 - rust-lang#73861 (Create E0768)
 - rust-lang#73881 (Standardize bibliographic citations in rustc API docs)
 - rust-lang#73925 (Improve comments from rust-lang#72617, as suggested by RalfJung)
 - rust-lang#73949 ([mir-opt] Fix mis-optimization and other issues with the SimplifyArmIdentity pass)
 - rust-lang#73984 (Edit docs for rustc_data_structures::graph::scc)
 - rust-lang#73985 (Fix "getting started" link)
 - rust-lang#73997 (fix typo)
 - rust-lang#73999 (Bump mingw-check CI image from Ubuntu 16.04 to 18.04.)

Failed merges:

 - rust-lang#74000 (add `lazy_normalization_consts` feature gate)

r? @ghost
@bors bors merged commit 50dcefc into rust-lang:master Jul 4, 2020
@cuviper cuviper added this to the 1.46 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

@RalfJung RalfJung RalfJung left review comments

Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.46
Development

Successfully merging this pull request may close these issues.
6 participants
@wesleywiser @rust-highfive @RalfJung @oli-obk @bors @cuviper